Skip to content

Default to Kubernetes 1.24 #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 8, 2022
Merged

Default to Kubernetes 1.24 #859

merged 3 commits into from
Aug 8, 2022

Conversation

skitt
Copy link
Member

@skitt skitt commented Jul 6, 2022 •
edited
Loading

Signed-off-by: Stephen Kitt [email protected]

Depends on submariner-io/lighthouse#791
Depends on submariner-io/admiral#388

@submariner-bot
Copy link

🤖 Created branch: z_pr859/skitt/default-k8s-1.24

@skitt skitt mentioned this pull request Jul 6, 2022
Merged
@skitt
Copy link
Member Author

skitt commented Jul 6, 2022 •
edited
Loading

The upgrade job won’t work until we release 0.13.0 or 0.12.2. (0.12.1 doesn’t support Kubernetes 1.24.)

@dfarrell07
Copy link
Member

The Helm jobs will fail because of submariner-io/submariner-charts#236.

@submariner-bot
Copy link

🤖 The base of this PR has been updated to devel
Please rebase this branch and remove #859 related commits

@submariner-bot submariner-bot changed the base branch from z_pr852/skitt/k8s-1.24-kind-0.14 to devel July 6, 2022 17:13
mkolesnik
mkolesnik requested changes Jul 7, 2022
View reviewed changes
skitt added a commit to skitt/shipyard that referenced this pull request Jul 7, 2022
@skitt
Clean up clusters.sh
cf38b66 
... following review comments on
submariner-io#859

Signed-off-by: Stephen Kitt <[email protected]>
@skitt skitt mentioned this pull request Jul 7, 2022
Merged
@skitt
Copy link
Member Author

skitt commented Jul 7, 2022 •
edited
Loading

@mkolesnik I’ve addressed your review comments in #864 (the code you were reviewing was already merged).

@skitt skitt force-pushed the default-k8s-1.24 branch from 021b830 to c1fa982 Compare July 7, 2022 07:46
skitt added a commit to skitt/shipyard that referenced this pull request Jul 7, 2022
@skitt
Clean up clusters.sh
3c76cee 
... following review comments on
submariner-io#859

* Drop the stutter in "kind_kind_binaries"
* Remove the 1.14 shas, they'll change anyway
* Default to kind and remove the explicit declarations for 1.17-1.23
* Don't log the kind binary explicitly, it's visible in the logs
* Quote "${kind}"

Signed-off-by: Stephen Kitt <[email protected]>
@dfarrell07 dfarrell07 requested a review from mkolesnik July 8, 2022 22:44
@skitt skitt force-pushed the default-k8s-1.24 branch from c1fa982 to 1346ba8 Compare July 11, 2022 13:58
@skitt
Copy link
Member Author

skitt commented Jul 15, 2022

The Helm jobs are now fixed.

@mkolesnik this is blocked by your request for changes, which doesn’t apply to this PR.

@skitt skitt added blocked-on-rereview Review feedback has been addressed, waiting on reviewer to re-review. e2e-projects Run E2E tests in each consuming project labels Jul 15, 2022
dfarrell07 pushed a commit that referenced this pull request Jul 18, 2022
@skitt @dfarrell07
Clean up clusters.sh
9932f01 
... following review comments on
#859

* Drop the stutter in "kind_kind_binaries"
* Remove the 1.14 shas, they'll change anyway
* Default to kind and remove the explicit declarations for 1.17-1.23
* Don't log the kind binary explicitly, it's visible in the logs
* Quote "${kind}"

Signed-off-by: Stephen Kitt <[email protected]>
@skitt skitt force-pushed the default-k8s-1.24 branch from cef6d51 to bad1eac Compare July 19, 2022 13:17
@tpantelis
Copy link
Contributor

I think we want to hold off on this until the lighthouse E2E resource issue 0.24 is resolved.

@skitt
Copy link
Member Author

skitt commented Jul 19, 2022

I think we want to hold off on this until the lighthouse E2E resource issue 0.24 is resolved.

Could you add that as a “request for changes” so it blocks the merge? Thanks! (I can’t do it since this is my own PR.)

tpantelis
tpantelis requested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@tpantelis tpantelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold this until the lighthouse issues are fixed.

@mkolesnik mkolesnik mentioned this pull request Jul 20, 2022
Closed
@mkolesnik
Copy link
Collaborator

Could you add that as a “request for changes” so it blocks the merge? Thanks! (I can’t do it since this is my own PR.)

I added it as "depends on", isn't that the preferred way of doing it? :)

FWIW on LH this change won't affect the CI, but obviously when deployed manually one could potentially hit some issues, so I guess it makes sense to wait on LH CI to pass to be sure.

We can also see jobs failing "E2E Consuming", including admiral which I think merits an investigation.

@skitt
Copy link
Member Author

skitt commented Jul 20, 2022

Could you add that as a “request for changes” so it blocks the merge? Thanks! (I can’t do it since this is my own PR.)

I added it as "depends on", isn't that the preferred way of doing it? :)

FWIW on LH this change won't affect the CI, but obviously when deployed manually one could potentially hit some issues, so I guess it makes sense to wait on LH CI to pass to be sure.

We can also see jobs failing "E2E Consuming", including admiral which I think merits an investigation.

I was thinking of the latter, and since they aren’t “Required” (the Lighthouse ones are failing, as well as Admiral), I wanted to avoid an accidental merge before they were fixed.

dfarrell07
dfarrell07 requested changes Jul 20, 2022
View reviewed changes
Copy link
Member

@dfarrell07 dfarrell07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes until the not-required Consuming Projects / E2E Consuming (admiral, operator, libreswan, 1.24) job is passing.

@skitt skitt removed the blocked-on-rereview Review feedback has been addressed, waiting on reviewer to re-review. label Jul 22, 2022
@skitt skitt force-pushed the default-k8s-1.24 branch from bad1eac to c45b742 Compare August 2, 2022 15:24
@skitt
Default to Kubernetes 1.24
231a1c7 
Signed-off-by: Stephen Kitt <[email protected]>
@skitt skitt force-pushed the default-k8s-1.24 branch from c45b742 to 231a1c7 Compare August 4, 2022 15:41
@tpantelis
Copy link
Contributor

Requesting changes until the not-required Consuming Projects / E2E Consuming (admiral, operator, libreswan, 1.24) job is passing.

It's passing now.

@github-actions github-actions bot removed the dependent label Aug 5, 2022
@github-actions
Copy link

github-actions bot commented Aug 5, 2022

This PR/issue depends on:

@tpantelis tpantelis requested a review from dfarrell07 August 5, 2022 13:37
@skitt
Copy link
Member Author

skitt commented Aug 8, 2022

@dfarrell07 could you update your review?

@tpantelis tpantelis merged commit b24e6f7 into submariner-io:devel Aug 8, 2022
@submariner-bot
Copy link

🤖 Closed branches: [z_pr859/skitt/default-k8s-1.24]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfarrell07 dfarrell07 dfarrell07 approved these changes

@sridhargaddam sridhargaddam sridhargaddam approved these changes

@tpantelis tpantelis tpantelis approved these changes

@mkolesnik mkolesnik mkolesnik approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

Assignees
No one assigned
Labels
e2e-projects Run E2E tests in each consuming project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skitt @submariner-bot @dfarrell07 @tpantelis @mkolesnik @sridhargaddam